-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multicore http server #250
base: master
Are you sure you want to change the base?
multicore http server #250
Conversation
@orangejulius I did some basic testing on this and found that using multicore and libpostal service resulted in worse performance than running it single-threaded using the npm module. Maybe there's an error in how I'm using the async code or something else going on? |
Yeah, I recall experiencing and reading about poor performance from the After all, it's essentially a load balancing layer where different Node.js processes are communicating with each other. I imagine it's not nearly as efficient as say, Nginx in front of several identical Node.js processes reading from the same SQLite DB. |
afc85ab
to
d4678cf
Compare
d4678cf
to
dadecb7
Compare
This draft PR is #249 plus a single commit to add multi-core support to the http server via the
cluster
module.When using the
node-postal
'module' adapter it is recommended to set the env varCPUS=1
to force the server single-threaded.